Template talk:Amstrad Action

This template doesn't work anymore.

{{Amstrad Action|1|004|aa04-80%5B1%5D.jpeg}} this links to broken:

https://www.cpcwiki.eu/mags/ALMags/AA/004/jpeg/aa04-80%5b1%5d.jpeg

In the same fashion this could work:

{{Amstrad Action|1|7|79|AmstradAction004--080.jpg}}

[https://www.cpcwiki.eu/imgs/{{{2}}}/{{{3}}}/{{4}} {{{1}}}]<noinclude>[[Category:Magazine link templates|Amstrad action]] </noinclude>

https://www.cpcwiki.eu/imgs/7/79/AmstradAction004--080.jpg

Or even better:

{{Amstrad Action|ref|issue|page}}

[https://www.cpcwiki.eu/index.php/File:AmstradAction{{{2}}}--{{{3}}}.jpg {{{1}}}]

--Cibersheep (talk) 14:04, 20 April 2022 (UTC)

This is a strange template! The third parameter contains a full filename so it would have been as easy to have done without a template at all. I've fixed it so that it takes the same parameters (using some parser functions to get the page number from the filename) but uses ifarchive.org links instead of cpcwiki.eu - so there should be no need to edit the Amstrad Action content page. It works on the links I've checked but I haven't checked every link. Jonathan (talk) 07:33, 23 April 2022 (UTC)

I haven't time right now, but it will be easy to change the template so that the third parameter can be the old filename or (for future use) just a page number. In the meantime you could add a hyphen before the page number. Jonathan (talk) 07:43, 23 April 2022 (UTC)

Ok, I think this works now. Jonathan (talk) 08:52, 23 April 2022 (UTC)

Oh, that's really nice. Thank you! Great work

--Cibersheep (talk) 21:23, 23 April 2022 (UTC)